mvcextensions Issue Tracker Rss Feed

Closed Issue: ModelMetadataItem - invalid default values [20]

hazzik — Sun, 18 Dec 2011 18:22:49 GMT

There some discrepancies between ModelMetadataItem (MvcExtensions) and ModelMetadata (built-in mvc class from System.Web.Mvc) default property values. That makes different behavior for models with MvcExtensions and DataAnnotations attributes.
Here is a list of fields for ModelMetadataItem need to be set:
public ModelMetadataItem()
{
ShowForDisplay = true;
ShowForEdit = true;
ConvertEmptyStringToNull = true;
Order = 10000;
RequestValidationEnabled = true;

Validations = new List<IModelValidationMetadata>();
AdditionalSettings = new List<IModelMetadataAdditionalSetting>();
}

If you take a look at ModelMetadata, you'll see these values:

private bool _convertEmptyStringToNull = true;
private int _order = 10000;
private bool _requestValidationEnabled = true;
private bool _showForDisplay = true;
private bool _showForEdit = true;

....

Example: to reproduce the bug you create simple model
class MyModel
{
public string Field1 {get;set;}
public string Field2 {get;set;}
}

public class MyModelModelConfiguration : ModelMetadataConfiguration<MyModel>
{
Configure(model => model.Field1).DisplayName("SomeName");
// no any settings for Field2
}

If user does not entered both fields, we'll get a model with Field1 == "" and Field2 == null. (that's bacause of ConvertEmptyStringToNull is false by default in MvcExtensions)

Commented Issue: ModelMetadataItem - invalid default values [20]

hazzik — Sun, 18 Dec 2011 18:22:41 GMT

Created Issue: ModelMetadataItem - invalid default values [20]

AlexBar — Sat, 17 Dec 2011 13:41:51 GMT

Created Issue: Globally defined resource item for validation messages [19]

AlexBar — Sat, 10 Dec 2011 19:49:52 GMT

It would be cool to have a feature to set validation message globally like:

ModelMetadataSetting.RequredErrorMessage = () => ResourceMessages.Requred; // run at user's bootstrapper task

And then use it as
...
Configure(s => s.SomeField).Required(); // global defined message will be used; user should be able to override the default message, of course.
...

Edited Issue: Unable to use asynchronous controllers [8]

hazzik — Sat, 29 Oct 2011 18:27:10 GMT

I just realized that I'm unable to use asynchronous controllers with MVC Extensions. The cause for this is the custom ExtendedControllerActionInvoker. I believe this needs to be changed to inherit from AsyncControllerActionInvoker. I've changed it myself locally and am testing it now.

Commented Issue: Debugging Codeplex MVCExtensions in 4.0 throws exception [13]

hazzik — Sat, 29 Oct 2011 18:25:29 GMT

download http://mvcextensions.codeplex.com/

1. On the same project as above. Start VS as admin

2. Open the solution

3. For project demo\demo.web.unity, make it IIS WAP and save

4. Rebuild the solution

5. Debug The demo.web.utility application by browsing to the root of the application

6. Do an iisreset and browse to the page again

Actual:

w3wp.exe throws exception, you can see function OnBeginRequest function get called repeatly and caused System.StackOverflowException.

Comments: Cant' reproduce

Edited Issue: Debugging Codeplex MVCExtensions in 4.0 throws exception [13]

hazzik — Sat, 29 Oct 2011 18:25:29 GMT

Commented Issue: Cleanup() method throws an exception when using Autofac [18]

hazzik — Sat, 29 Oct 2011 17:53:21 GMT

Edited Issue: Cleanup() method throws an exception when using Autofac [18]

hazzik — Sat, 29 Oct 2011 17:53:21 GMT

Edited Issue: error: no parameterless constructor [17]

hazzik — Sat, 29 Oct 2011 16:18:02 GMT

MvcExtensions trying to create controller with activator if it cannot be created with ioc container.

Reopened Issue: error: no parameterless constructor [17]

hazzik — Sat, 29 Oct 2011 16:17:51 GMT

MvcExtensions trying to create controller with activator if it cannot be created with ioc container.

Closed Issue: error: no parameterless constructor [17]

hazzik — Sat, 29 Oct 2011 16:17:47 GMT

MvcExtensions trying to create controller with activator if it cannot be created with ioc container.

Commented Issue: error: no parameterless constructor [17]

hazzik — Sat, 29 Oct 2011 16:17:36 GMT

MvcExtensions trying to create controller with activator if it cannot be created with ioc container.
Comments: Should be resolved in 2.0.1.520. Now inner container throws exception, if component is registered, but can not be resolved properly.

Edited Issue: error: no parameterless constructor [17]

hazzik — Sat, 29 Oct 2011 16:17:36 GMT

MvcExtensions trying to create controller with activator if it cannot be created with ioc container.

Commented Issue: Cleanup() method throws an exception when using Autofac [18]

AlexBar — Sat, 29 Oct 2011 15:07:25 GMT

1. Reproduced on latest version 4f50ae05c0d6
2. When MvcExtensions.Bootstrapper.Cleanup() is executed, it throws an exception

System.NullReferenceException: Object reference not set to an instance of an object.
at MvcExtensions.Bootstrapper.Cleanup[TTask](IEnumerable`1 tasks) in d:\BuildAgent-02\work\79d4d30b62db7cc8\Trunk\MvcExtensions\Bootstrapper\Bootstrapper.cs:line 191
at MvcExtensions.Bootstrapper.DisposeBootstrapperTasks() in d:\BuildAgent-02\work\79d4d30b62db7cc8\Trunk\MvcExtensions\Bootstrapper\Bootstrapper.cs:line 112
at MvcExtensions.ExtendedMvcApplication.Application_End() in d:\BuildAgent-02\work\79d4d30b62db7cc8\Trunk\MvcExtensions\ExtendedMvcApplication.cs:line 84

The root cause of this exception is in RequestLifetimeScopeProvider implemention. It resolves HttpContextBase from container, but at the moment when Cleanup() method is called, HttpContext.Current == null and we'll get such error.

HttpContextBase is registered as:
builder.Register(c => new HttpContextWrapper(HttpContext.Current)).As<HttpContextBase>().InstancePerDependency();

PS why didn't you use Autofac implementetion of RequestLifetimeScopeProvider (http://code.google.com/p/autofac/source/browse/src/Source/Autofac.Integration.Mvc/RequestLifetimeScopeProvider.cs)? It would be useful to use default implementation especially if I'm trying to intergete MvcExtention with existing project that already uses Autofac.Mvc features. I'm going to use only ModelMetadate feature.

Comments: Solution: Change private ILifetimeScope LifetimeScope { get { return (ILifetimeScope)container.Resolve<HttpContextBase>().Items[lifettymeScopeType]; } set { container.Resolve<HttpContextBase>().Items[lifettymeScopeType] = value; } } with private ILifetimeScope LifetimeScope { get { return (ILifetimeScope)HttpContext.Current.Items[lifettymeScopeType]; } set { HttpContext.Current.Items[lifettymeScopeType] = value; } } It solves the problem. + builder.Register(c => new HttpContextWrapper(HttpContext.Current)).As<HttpContextBase>().InstancePerDependency(); can and should be removed. Let user to register it himself. Change tests: public class AutofacAdapterTests { private readonly AutofacAdapter adapter; public AutofacAdapterTests() { HttpContext.Current = new HttpContext(new HttpRequest("", "http://tempuri.org", ""), new HttpResponse(new StringWriter())); var httpContextMock = new Mock<HttpContextBase>(); httpContextMock.Setup(x => x.Items).Returns(new Hashtable()); var builder = new ContainerBuilder(); adapter = new AutofacAdapter(builder.Build()); } ...

Created Issue: Cleanup() method throws an exception when using Autofac [18]

AlexBar — Sat, 29 Oct 2011 14:37:12 GMT

Edited Issue: error: no parameterless constructor [17]

hazzik — Mon, 26 Sep 2011 05:05:50 GMT

MvcExtensions trying to create controller with activator if it cannot be created with ioc container.

Created Issue: error: no parameterless constructor [17]

hazzik — Mon, 26 Sep 2011 05:05:22 GMT

MvcExtensions trying to create controller with activator if it cannot be created with ioc container. I gues somthing wrong with lifetime of one or more component on which controller depends.

I've added debug information for situation when container throws exception on type resolution. please check this http://mvcextensions.codeplex.com/SourceControl/changeset/changes/bea5a08df651

Reopened Issue: ModelMetadataConfiguration Typed AsDropDownList [6]

hazzik — Mon, 01 Aug 2011 17:08:19 GMT

The extension AsDropDownList could have an typed version, so this way I don't need to use the viewData.

Closed Issue: Assembly version for RTM and SP1 Preview is same at 1.0.0.0 [4]

hazzik — Mon, 01 Aug 2011 11:00:17 GMT

Unless this is intentional for some reason